You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Designed to fix the issue with codeSigningInfo not working when both mac.cscLink and mas.cscLink are defined with separate values. It currently only creates the codeSigningInfo value once and then reuses that across all other targets. Outlined here #8280.
A simpler approach would be to stop wrapping the execution of codeSigningInfo within the Lazy class, but this PR tries to preserve most of the existing behaviour.
Please close/ignore this if you deem it is working as intended. I can otherwise use patch-package to fix this, without maintaining a forked repo.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Made some minor modifications, such as adding deep equals functionality via recursion and a unit test. Also updated winPackager csc signing logic to use the MemoLazy class now since I think it'll run into the same issue when having multiple Window targets.
Largest changes in the PR are just from regenerating the API docs.
Figured we could merge this in to resolve the issue and once the upstream PR is accepted, we can remove the local MemoLazy in favor of upstream.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mmaietta
force-pushed
the
fix-unable-to-codesign-multi-targets-#8280
branch
from
Designed to fix the issue with
codeSigningInfonot working when bothmac.cscLinkandmas.cscLinkare defined with separate values. It currently only creates thecodeSigningInfovalue once and then reuses that across all other targets. Outlined here #8280.A simpler approach would be to stop wrapping the execution of
codeSigningInfowithin theLazyclass, but this PR tries to preserve most of the existing behaviour.Please close/ignore this if you deem it is working as intended. I can otherwise use patch-package to fix this, without maintaining a forked repo.
Thanks for your time!