-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mac): support macos signature additionalArguments parameter #8218
Conversation
🦋 Changeset detectedLatest commit: 17fd5e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for your contribution! Could you please update electron/osx-sign package as part of the PR? Looks like we're pinned to 1.0.5 |
Oh, damn it, I forgot to submit the package.json file. Thank you for reminding me @mmaietta |
Due to the higher pnpm version of the local environment, the pnpm-lock.yaml file has been greatly changed, so I choose to ignore the submission of the file (thus may lead to the failure of ci). If there is anything that can help, I can cooperate. |
I gotcha. Updated the pnpm-lock.yaml and added a changeset |
Update electron/osx-sign, add macos signing option
additionalArguments
.electron/osx-sign#316
https://github.com/electron/osx-sign?tab=readme-ov-file#signing-with---deep
@develar @mmaietta TBR;