Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appx): Update identityName for windows 10 #8206

Merged
merged 16 commits into from
Jun 8, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(appx): add check application id test and fix detect null application
ifurther committed May 9, 2024
commit 83aad7d6399359ca61562d088f1f8a543454c687
2 changes: 1 addition & 1 deletion packages/app-builder-lib/src/targets/AppxTarget.ts
Original file line number Diff line number Diff line change
@@ -235,7 +235,7 @@ export default class AppXTarget extends Target {
} else if (restrictedApplicationIdValues.includes(result.toUpperCase())) {
const message = `AppX Application.Id cannot be some values`
throw new InvalidConfigurationError(message)
} else if (options.applicationId == null) {
} else if (result == null && options.applicationId == null) {
const message = `Please set appx.applicationId (or correct appx.identityName or name)`
throw new InvalidConfigurationError(message)
}
16 changes: 16 additions & 0 deletions test/src/windows/appxTest.ts
Original file line number Diff line number Diff line change
@@ -42,6 +42,22 @@ it.ifDevOrWinCi(
)
)

// use identityName and same setting for applicationId
it.ifDevOrWinCi(
"application id",
app(
{
targets: Platform.WINDOWS.createTarget(["appx"], Arch.x64),
config: {
appx: {
identityName: "01234Test.ApplicationDataSample",
},
},
},
{}
)
)

const it2 = isEnvTrue(process.env.DO_APPX_CERT_STORE_AWARE_TEST) ? test : test.skip
it2.ifNotCi(
"certificateSubjectName",