Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support mjs files for lifecycle operations #7442

Merged
merged 3 commits into from
Mar 3, 2023
Merged

feat: Support mjs files for lifecycle operations #7442

merged 3 commits into from
Mar 3, 2023

Conversation

Nokel81
Copy link
Contributor

@Nokel81 Nokel81 commented Feb 22, 2023

  • beforePack
  • afterSign
  • artifactBuildStarted
  • artifactBuildCompleted
  • appxManifestCreated
  • msiProjectCreated
  • beforeBuild
  • afterPack
  • afterAllArtifactBuild
  • sign
  • onNodeModuleFile

fixes #7441

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: be1af8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Minor
dmg-builder Minor
electron-builder-squirrel-windows Minor
electron-builder Minor
electron-forge-maker-appimage Minor
electron-forge-maker-nsis-web Minor
electron-forge-maker-nsis Minor
electron-forge-maker-snap Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 22, 2023 •
edited
Loading

✅ Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit be1af8a
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6401ffc5c0d4520008b5f6a2
😎 Deploy Preview https://deploy-preview-7442--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Nokel81 Nokel81 changed the title Support mjs files for lifecycle operations feat: Support mjs files for lifecycle operations Feb 22, 2023
@Nokel81
Copy link
Contributor Author

Nokel81 commented Mar 1, 2023

@mmaietta Tested locally using the electron-react-boilerplate repo and both a "buildBuild": "./scripts/beforeBuild.mjs" and a "buildBuild": "./scripts/beforeBuild.js" run. They work. Though I had to put a fix in.

@mmaietta
Copy link
Collaborator

mmaietta commented Mar 2, 2023

Can you please rebase off latest master? It seems there was a random integration test that started failing, causing all linux tests across PRs to fail.

Nokel81 added 3 commits March 3, 2023 09:09
@Nokel81
Support mjs files for lifecycle operations
81a282f 
- beforePack
- afterSign
- artifactBuildStarted
- artifactBuildCompleted
- appxManifestCreated
- msiProjectCreated
- beforeBuild
- afterPack
- afterAllArtifactBuild
- sign
- onNodeModuleFile

Signed-off-by: Sebastian Malton <[email protected]>
@Nokel81
Add changeset
57a3d08 
Signed-off-by: Sebastian Malton <[email protected]>
@Nokel81
Fix dynamic imports
be1af8a 
Signed-off-by: Sebastian Malton <[email protected]>
@Nokel81 Nokel81 force-pushed the support-mjs-lifecycles branch from ee5f039 to be1af8a Compare March 3, 2023 14:10
@Nokel81
Copy link
Contributor Author

Nokel81 commented Mar 3, 2023

@mmaietta done

@mmaietta mmaietta merged commit 37d6db3 into electron-userland:master Mar 3, 2023
@github-actions github-actions bot mentioned this pull request Mar 3, 2023
Merged
@Nokel81 Nokel81 deleted the support-mjs-lifecycles branch March 3, 2023 15:36
mmaietta added a commit that referenced this pull request Mar 4, 2023
@mmaietta
Revert "feat: Support mjs files for lifecycle operations (#7442)"
926602d 
This reverts commit 37d6db3.
@mmaietta mmaietta mentioned this pull request Mar 4, 2023
Merged
mmaietta added a commit that referenced this pull request Mar 4, 2023
@mmaietta
fix: Revert "feat: Support mjs files for lifecycle operations" (#7461)
0f9da20 
* Revert "feat: Support mjs files for lifecycle operations (#7442)"

This reverts commit 37d6db3.
@mmaietta
Copy link
Collaborator

mmaietta commented Mar 4, 2023

Need to revert this PR until further testing is done.
#7461

Basically, Windows unit tests broke (that somehow I overlooked earlier?). It hangs and receives an Access Violation consistently - 3221225477 -> 0xC0000005

@Nokel81
Copy link
Contributor Author

Nokel81 commented Mar 4, 2023

Oh okay. I'll see if I can reproduce on a Windows machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaietta mmaietta mmaietta left review comments

Assignees
No one assigned
Labels
app-builder-lib windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

afterSign does not support mjs files
2 participants
@Nokel81 @mmaietta