Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve the code-signing-windows-apps-on-unix.md page #7377

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

popod
Copy link
Contributor

@popod popod commented Jan 14, 2023

The executable path is missing in the JSign procedure cmd and the configuration.path variable was not explicitly explained in the exemple script for signing.

I think that this two changes improve the code signing understanding.

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2023

⚠️ No Changeset found

Latest commit: 664a67b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jan 14, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 664a67b
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/63c2c6f075aefc0009ecdeca
😎 Deploy Preview https://deploy-preview-7377--car-park-attendant-cleat-11576.netlify.app/tutorials/code-signing-windows-apps-on-unix
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@popod popod changed the title Update the doc about code-signing-windows-apps-on-unix.md docs: improve the code-signing-windows-apps-on-unix.md page Jan 14, 2023
@mmaietta mmaietta merged commit 26a58e9 into electron-userland:master Jan 17, 2023
@popod popod deleted the patch-1 branch January 17, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants