Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update MacOS signOptions on macPackager #7317 #7351

Merged
merged 2 commits into from
Jan 6, 2023
Merged

fix: Update MacOS signOptions on macPackager #7317 #7351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42a213e
Update MacOS signOptions on macPackager, Fix #7317
filfreire Jan 5, 2023
a10003d
Remove legacy signOptions in macPackager
filfreire Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilled-shoes-sort.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-lib": minor
---

Update MacOS signOptions on macPackager
6 changes: 3 additions & 3 deletions packages/app-builder-lib/src/macPackager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
}

const signOptions: any = {
"identity-validation": false,
identityValidation: false,
// https://github.com/electron-userland/electron-builder/issues/1699
// kext are signed by the chipset manufacturers. You need a special certificate (only available on request) from Apple to be able to sign kext.
ignore: (file: string) => {
Expand All @@ -294,7 +294,7 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
https://github.com/electron-userland/electron-builder/issues/5383
*/
},
identity: identity,
identity: identity ? identity.name : undefined,
type,
platform: isMas ? "mas" : "darwin",
version: this.config.electronVersion,
Expand All @@ -307,7 +307,7 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
// will fail on 10.14.5+ because a signed but unnotarized app is also rejected.
"gatekeeper-assess": options.gatekeeperAssess === true,
// https://github.com/electron-userland/electron-builder/issues/1480
"strict-verify": options.strictVerify,
strictVerify: options.strictVerify,
hardenedRuntime: isMas ? masOptions && masOptions.hardenedRuntime === true : options.hardenedRuntime !== false,
}

Expand Down