Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: declare node-linker when using Yarn 3 #7113

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

ouliuquan
Copy link
Contributor

Because of yarn 3 use PnP by default, but electron-builder still need node-modules.
So add configuration in the .yarnrc.yaml:

nodeLinker: "node-modules"

will declare to use node-modules instead of PnP.

Because of yarn 3 use PnP by default, but electron-builder still need node-modules.
So add configuration in the  `.yarnrc.yaml`:
```
nodeLinker: "node-modules"
```
will declare to use node-modules instead of PnP.
@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2022

⚠️ No Changeset found

Latest commit: 9f4760b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 2, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 9f4760b
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/631199a30b0b770008c4a5ce
😎 Deploy Preview https://deploy-preview-7113--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta mmaietta merged commit 5eb002b into electron-userland:master Sep 2, 2022
@ouliuquan
Copy link
Contributor Author

#yarnpkg/berry#4804

@mmaietta
Copy link
Collaborator

mmaietta commented Nov 2, 2022

Thank you!

Can you please also add that info here so it is shown on the docs website?
https://github.com/electron-userland/electron-builder/blob/master/docs/index.md

@ouliuquan
Copy link
Contributor Author

Thank you!

Can you please also add that info here so it is shown on the docs website? https://github.com/electron-userland/electron-builder/blob/master/docs/index.md

Yeah, I had been create a PR for website here. #7233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants