Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent infinite looping of overwriteArtifact #6958

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

CCInc
Copy link
Contributor

@CCInc CCInc commented Jun 23, 2022

In the case that overriding an existing github artifact fails, it will continually retry until github reaches an API limit. This change should prevent retrying an unnecessary amount of times (but doesn't fix the root issue of why the override failed in the first place).

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2022

⚠️ No Changeset found

Latest commit: fc80d85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 23, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 08625c3
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/62b4724565d8b00008e68034
😎 Deploy Preview https://deploy-preview-6958--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta mmaietta merged commit 8ffd9d4 into electron-userland:master Jun 23, 2022
@github-actions github-actions bot mentioned this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants