-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: electron/universal has a new minimatch option 'x64ArchFiles' #6913
Conversation
🦋 Changeset detectedLatest commit: 8a1f846 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The CircleCI failures don't appear tied to this change. Is it local policy that you'd want a changeset for passing through a new config option? If so, I'd be happy to amend the PR. |
Some projects need to ship x64 binaries which will be run under Rosetta2 on arm64 Macs. This option allows a packager to specify that they're aware that certain files in their distribution which are included in both x64 and arm64 builds are actually x64 binaries in both builds. Without this option, electron/universal will attempt to lipo the two binaries together, resulting in a build failure.
I think this should be fine for now, but I'll need to make a breaking change in the future, as we're adding too many items to the |
Some projects need to ship x64 binaries which will be run under
Rosetta2 on arm64 Macs.
This option allows a packager to specify that they're aware that
certain files in their distribution which are included in both x64
and arm64 builds are actually x64 binaries in both builds.
Without this option, electron/universal will attempt to lipo
the two binaries together, resulting in a build failure.