Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add app-update.yml to avoid errors #6615

Closed
wants to merge 1 commit into from
Closed

Add app-update.yml to avoid errors #6615

wants to merge 1 commit into from

Conversation

customautosys
Copy link

Suggested fix for #6322 (not tested yet).

Add app-update.yml to avoid errors
74f64a8 
Suggested fix for electron-userland#6322 (not tested yet).
@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2022

⚠️ No Changeset found

Latest commit: 74f64a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Feb 5, 2022 •
edited
Loading

✔️ Deploy Preview for car-park-attendant-cleat-11576 ready!

🔨 Explore the source changes: 74f64a8

🔍 Inspect the deploy log: https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/61feb5ebec11e20008c691cd

😎 Browse the preview: https://deploy-preview-6615--car-park-attendant-cleat-11576.netlify.app

mmaietta
mmaietta reviewed Feb 5, 2022
View reviewed changes
packages/app-builder-lib/src/targets/snap.ts
const publishConfig = getAppUpdatePublishConfiguration(packager, arch, false /* in any case validation will be done on publish */)
if (publishConfig != null) {
await outputFile(path.join(packager.getResourcesDir(stageDir.dir), "app-update.yml"), serializeToYaml(publishConfig))
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this change, being applied to only snap, resovles the issue for deb/rpm builds that also do not support auto-updates.

@mmaietta mmaietta closed this Feb 9, 2022
@mmaietta
Copy link
Collaborator

mmaietta commented Feb 9, 2022

Closing, should be resolved through #6616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaietta mmaietta mmaietta left review comments

Assignees
No one assigned
Labels
app-builder-lib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@customautosys @mmaietta