Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mac): signing cert filter incorrectly selects certificates (#6094) (#6101) #6105

Merged
merged 2 commits into from
Jul 28, 2021
Merged

fix(mac): signing cert filter incorrectly selects certificates (#6094) (#6101) #6105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54b93ba
fix(mac): Adding Developer ID Application entry for development signi…
mmaietta Jul 28, 2021
5052700
Create great-pumas-trade.md
mmaietta Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/great-pumas-trade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"app-builder-lib": patch
---

fix(mac): Adding Developer ID Application entry for development signing when building not a mas target. Fixes: #6094
fix(mac): Removing 3rd Party Mac Developer Application certificate selector. Fixes: #6101
4 changes: 2 additions & 2 deletions packages/app-builder-lib/src/macPackager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {

function getCertificateTypes(isMas: boolean, isDevelopment: boolean): CertType[] {
if (isDevelopment) {
return ["Mac Developer", "Apple Development"]
return isMas ? ["Mac Developer", "Apple Development"] : ["Developer ID Application"]
}
return isMas ? ["3rd Party Mac Developer Application", "Apple Distribution"] : ["Developer ID Application"]
return isMas ? ["Apple Distribution"] : ["Developer ID Application"]
}