Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update downloadPlanBuilder.ts #5624

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Update downloadPlanBuilder.ts #5624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/electron-updater/src/differentialDownloader/downloadPlanBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ function buildChecksumMap(file: BlockMapFile, fileOffset: number, logger: Logger
const checksumToOffset = new Map<string, number>()
const checksumToSize = new Map<string, number>()
let offset = fileOffset
const debugLog = logger.debug
for (let i = 0; i < file.checksums.length; i++) {
const checksum = file.checksums[i]
const size = file.sizes[i]
Expand All @@ -120,9 +119,9 @@ function buildChecksumMap(file: BlockMapFile, fileOffset: number, logger: Logger
checksumToOffset.set(checksum, offset)
checksumToSize.set(checksum, size)
}
else if (debugLog != null) {
else if (logger.debug != null) {
const sizeExplanation = existing === size ? "(same size)" : `(size: ${existing}, this size: ${size})`
debugLog(`${checksum} duplicated in blockmap ${sizeExplanation}, it doesn't lead to broken differential downloader, just corresponding block will be skipped)`)
logger.debug(`${checksum} duplicated in blockmap ${sizeExplanation}, it doesn't lead to broken differential downloader, just corresponding block will be skipped)`)
}
offset += size
}
Expand Down