Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arm64): fix pacman build, pacman & rpm artifact names #5304

Merged
merged 1 commit into from
Nov 28, 2020

Conversation

cwillisf
Copy link
Contributor

Previous behavior: pacman files built for arm64 could not be installed. Instead, pacman would return errors similar to:

error: failed to prepare transaction (package architecture is not valid)
:: package yourpackage-arm64 does not have a valid architecture

New behavior: pacman files built for arm64 install correctly.

This change corrects the value returned by toLinuxArchString when arch is Arch.arm64 and targetName is pacman. Pacman calls this architecture aarch64 whereas other targets call it arm64. Compare to the existing code for ia32, which pacman calls i686 and others call i386.

This change also adjusts the value returned by getArtifactArchName to better match convention when arch is Arch.arm64: both pacman and rpm use aarch64 in package file names for this architecture. There may be more cases here which need to be corrected, but I'm currently only aware of these two.

@stale stale bot added the backlog label Nov 21, 2020
@develar develar merged commit 069eba1 into electron-userland:master Nov 28, 2020
@electron-userland electron-userland deleted a comment from stale bot Nov 28, 2020
@develar develar removed the backlog label Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants