fix(arm64): fix pacman build, pacman & rpm artifact names #5304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior:
pacman
files built forarm64
could not be installed. Instead,pacman
would return errors similar to:New behavior:
pacman
files built forarm64
install correctly.This change corrects the value returned by
toLinuxArchString
whenarch
isArch.arm64
andtargetName
ispacman
. Pacman calls this architectureaarch64
whereas other targets call itarm64
. Compare to the existing code foria32
, whichpacman
callsi686
and others calli386
.This change also adjusts the value returned by
getArtifactArchName
to better match convention whenarch
isArch.arm64
: bothpacman
andrpm
useaarch64
in package file names for this architecture. There may be more cases here which need to be corrected, but I'm currently only aware of these two.