Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nsis): output files sometimes locked by virus scanners (#5005) #5143

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Conversation

berkon
Copy link
Contributor

@berkon berkon commented Jul 15, 2020

This fixes an issue which I've observed (and documented in issue #5005) with a McAfee virus scanner: After NSIS is writing the first part of the EXE, the virus scanner locks the file for further writing for a while, which causes the second write to fail and makes it impossible to build on my work laptop, because I'm not allowed to exclude certain files from the scanner. This fix checks whether the file is writable. If not it waits and checks again every 2s until the file is released by the scanner. A corresponding message is written to the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants