Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NSIS web build #4620

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Conversation

VeselyT
Copy link
Contributor

@VeselyT VeselyT commented Jan 28, 2020

This fixes #4402. More specifically error !insertmacro: macro "_If" requires 4 parameter(s), passed 6! during build of nsis-web target

@kzimny
Copy link

kzimny commented Jan 29, 2020

@VeselyT thank you!

@develar develar merged commit d5a00c3 into electron-userland:master Feb 2, 2020
@jwheare
Copy link
Contributor

jwheare commented Feb 11, 2020

@develar could we have a release for this fix?

@MartB
Copy link

MartB commented Feb 22, 2020

Is this already released?

@kzimny
Copy link

kzimny commented Feb 22, 2020

Should be in 22.3.3@next

@MartB
Copy link

MartB commented Feb 22, 2020

Im still getting this with 22.3.3

!insertmacro: macro "_If" requires 4 parameter(s), passed 6!
Error in macro downloadApplicationFiles on macroline 19
Error in macro installApplicationFiles on macroline 63
!include: error in script: "installSection.nsh" on line 60

@kzimny
Copy link

kzimny commented Feb 23, 2020

Indeed it doesn't work in v.22.3.2 and in v.22.3.3. The issue should be fixed in v.22.3.2 v22.3.2...master
@VeselyT: does it work yon your side?

@VeselyT
Copy link
Contributor Author

VeselyT commented Feb 27, 2020

@kzimny sorry for the late response... The fix is not present in v22.3.3 that is published on npm. However, it is included in v22.3.5 and it seems to work fine for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in release 22.1.0 "[object Object] error Command failed with exit code 1."
5 participants