Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Jenkins build number support #373

Merged
merged 1 commit into from May 2, 2016
Merged

add Jenkins build number support #373

merged 1 commit into from May 2, 2016

Conversation

ghost
Copy link

@ghost ghost commented May 2, 2016

Jenkins stores the build number in the BUILD_NUMBER environment variable

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @develar, @demetris-manikas and @pauliusuza to be potential reviewers

Jenkins stores the build number in the `BUILD_NUMBER` environment variable
@develar develar merged commit eebe882 into electron-userland:master May 2, 2016
@hetal-patadia
Copy link

hetal-patadia commented May 4, 2016

I would really like to use this feature (adding build number in the app version through Jenkins). Is there any documentation around it?

@develar
Copy link
Member

develar commented May 5, 2016

@hetal-patadia
Copy link

hetal-patadia commented May 5, 2016

Thanks @develar for the link. I tried that on my Jenkins server and it does set the CFBundleVersion, but does not set the version.build_number in CFBundleShortVersionString. Is it an issue or a known behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants