feat: check application package #355
Conversation
|
By analyzing the blame information on this pull request, we identified @develar and @pauliusuza to be potential reviewers |
| @@ -24,6 +24,8 @@ export interface AppMetadata extends Metadata { | |||
| */ | |||
| readonly description: string | |||
|
|
|||
| readonly main?: string | |||
There was a problem hiding this comment.
I think we should not add such option. User should use standard package.json main. And, so, our check should check such field in the package.json.
There was a problem hiding this comment.
If I understood correctly interface AppMetadata holds all "useful" properties of the application package.json for the sake ot typesafety. I thought I only gave access to main (an already existent option). Please correct me if I am wrong.
|
I think, we should perform this check before pack to asar due to performance reason. i.e. — when app dir detected, we check it. Before pack, not after. |
|
Well, then your comment that I should be aware of asar what was it for? |
|
So should I apply the validation before or after packaging? |
Sorry, it was just a proposal. After your changes I see that we can just use app dir. Also, it will fix OS X — currently, it is broken because on OS X path to On other hand — I doubt that it will be a bottleneck (it seems, getting contents of asar file is very quickly). And, strictly speaking, it is better to check the final result, not intermediate. So, 👍 to current ASAR check, just fix OS X. |
| } | ||
|
|
||
| private async statPackageFile(appOutDir: string, packageFile: string, isAsar: boolean): Promise<any> { | ||
| let fpath = path.resolve("/", packageFile) |
There was a problem hiding this comment.
Please consider to use const here (and in other places).
|
Also, please add |
demetris-manikas
force-pushed
the
FEAT-check-app-package
branch
from
6bba099 to
63cf201
Compare
demetris-manikas
force-pushed
the
FEAT-check-app-package
branch
from
63cf201 to
5138b0d
Compare
|
I believe all is done. |
|
Thank you! |
No description provided.