Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use 7za to produce Squirrel.mac zip (smaller size — the same ti… #293

Merged
merged 1 commit into from
Apr 5, 2016

Conversation

develar
Copy link
Member

@develar develar commented Apr 5, 2016

…me to compress)

Also, add compression option to set compression level in one place (currently, only Linux and OS X supported)

…me to compress)

Also, add compression option to set compression level in one place (currently, only Linux and OS X supported)
@develar develar merged commit 2dd5d7c into electron-userland:master Apr 5, 2016
@develar develar deleted the 7za-mac branch April 5, 2016 08:56
@asethwright
Copy link

Is there a dependency requirement for 7za I'm missing? I am getting errors on my build.

Packaging app for platform darwin x64 using electron v0.37.3
App is not signed: CSC_LINK or CSC_NAME are not specified
Creating DMG
Creating ZIP for Squirrel.Mac
.../node_modules/electron-builder/vendor/osx/7za: line 1: version: command not found
.../node_modules/electron-builder/vendor/osx/7za: line 2: oid: command not found
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/size: 1667792: No such file or directory.

@asethwright
Copy link

I tried brew install p7zip

which 7za
/usr/local/bin/7za

Will be glad to open an issue if needed. Thanks for your time. This makes building so easy.

@develar
Copy link
Member Author

develar commented Apr 9, 2016

@asethwright #296

@asethwright
Copy link

Ah, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants