Snap: initialize db and icons for faster startup and remove fonts #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
force-pushed
the
snap-faster-startup
branch
2 times, most recently
from
2b5e1ea to
eb3b06f
Compare
In order to improve the startup time for snapped
applications we can generate the mime DB and the
icon caches at snap build time.
In order to do this, we can use snap composition to
override the desktop-gtk{2,3} part, adding an install
script which does this.
The remote part can't do this by default since it
could break legacy applications providing such files
but this won't be the case for electron apps.
When the desktop-interface is used the snap has access to the system fonts, so there's no point of adding such files to the final snap.
3v1n0
force-pushed
the
snap-faster-startup
branch
from
eb3b06f to
ce9739b
Compare
|
Thanks! I will merge PR on weekend, since I need to test it manually. |
|
electron-builder doesn't user snapcraft if nothing custom specified and x64 arch. Instead, template used (that built in-prior, e.g. https://github.com/electron-userland/electron-builder-binaries/releases/tag/snap-template-2). It means, that we need to apply this logic for our template and do not add it not required (since part of template app). I will rebuild templates this week. |
develar
added a commit
to develar/electron-builder
that referenced
this pull request
Mar 26, 2018
develar
added a commit
that referenced
this pull request
Mar 26, 2018
|
electron-builder 20.8.0 released, template app updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve the startup time for snapped applications we can generate the mime DB and the icon caches at snap build time. In order to do this, we can use snap composition to override the desktop-gtk{2,3} part, adding an install script which does this.
The remote part can't do this by default since it could break legacy applications providing such files but this won't be the case for electron apps.
At the same time, fonts can be removed if a desktop plug is required since
/usr/share/fontswill be bind-mounted from system.