Remove encodeUri from squirrel-windows packaging

[rkistner]

Since Squirrel.Windows 1.7.x, Squirrel doesn't do URI encoding or decoding of paths anymore. Having encodeUri in here leaves the filenames in the escaped form after installation, which causes some issues.

Fixes #2557.

[develar]

Thanks a lot. Have you build your app with this change?

[rkistner]

For my app I made this change directly to the built JS file (it's a lot more effort to use a forked repo).

Initial testing looks good, but I still have to test what happens when upgrading from a very old version (where Squirrel still does the unescaping) to the new build.

[develar]

Ignore CI failure — I will fix snapshots.

[rkistner]

I've confirmed that this works for my case for:

• A fresh install.
• Upgrading from an electron-builder 19.49.0 build.
• Upgrading from an electron-builder 5.23.2 build.

In all those cases the exe is correctly installed as My Application.exe (not My%20Application.exe), and electron.autoUpdater.quitAndInstall() worked as expected.

However, I only tested the case with a space in the name - I did not test any non-ASCII characters (I'm not that familiar with how the encoding is supposed to work in those cases).

[develar]

Could you please set product name to 真实光影V4低配 and test setup?

[rkistner]

That does seem to work, both for clean install and on update:

The MSI installer does fail to build with a name like that, but I believe that's an unrelated limitation (same happens without this change).

[develar]

Thanks. Fix will be applied and released tomorrow evening CET.

[rkistner]

Thanks!