feat: ability to provide linux icon set #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We use sharp instead of gm because "Most Windows (x64), Linux and ARMv6+ systems do not require the installation of any external runtime dependencies." |
develar
force-pushed
the
linux-icon
branch
2 times, most recently
from
6ff6787 to
fa54be2
Compare
|
Blocked on lovell/sharp#378 |
develar
force-pushed
the
linux-icon
branch
7 times, most recently
from
bbadce7 to
689c4a9
Compare
24x24, 48x48, 64x64, 96x96 and 128x128 icons will be generated if missed in the ICNS You can provide Linux icon set explicitly — create `icons` folder in the `build`
develar
added a commit
that referenced
this pull request
Mar 17, 2016
feat: ability to provide linux icon set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build/icons will be used as a source of Linux app icons if exists.
Or ICNS file will be converted – now we produce all missed required linux sizes — 24, 64, 96.