I'd like to make computeSignToolArgs usable in custom signing. #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2017 11:41
cscInfo should still be calculated for a custom sign if applicable. -- Making this change because I want to use computeSignToolArgs in my custom signer and it was blowing up due to unexpected null references with this change.
|
CI passed, but I am not sure that solution is correct.
Could you please clarify why it is not usable now? If because your custom signer still want to get code singing info, please explain why. |
|
Right now if you call it, for example: configuration.computeSignToolArgs(true);It blows up inside windowsCodeSign.ts on const certificateFile = (options.cscInfo as FileCodeSigningInfo).fileBecause it's undefined, undefined.file throws an error. I thought the args were handy to have, because I'm using Parallels to run the signing, but I'm manually making the calls for other reasons. |
develar
added a commit
to develar/electron-builder
that referenced
this pull request
Mar 17, 2018
develar
added a commit
to develar/electron-builder
that referenced
this pull request
Mar 17, 2018
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
computeSignToolArgs is available on the configuration object passed into a custom signing method. This was really helpful to me, but in order to make it usable I had to remove the custom sign check from the winPackager.
I'm not sure if it's the best way to solve the issue, but in my view we can just leave out certificateSubjectName and certificateSha1 and certificateFile for the same effect. Either way, I wanted to create this pull request so that it could be discussed.
Thanks for all of your fantastic work - this tool has been awesome.