feat: #1547 Added pkg license #2212
Conversation
| @@ -70,6 +71,11 @@ export class PkgTarget extends Target { | |||
| let distInfo = await readFile(distInfoFile, "utf-8") | |||
| const insertIndex = distInfo.lastIndexOf("</installer-gui-script>") | |||
| distInfo = distInfo.substring(0, insertIndex) + ` <domains enable_anywhere="${options.allowAnywhere}" enable_currentUserHome="${options.allowCurrentUserHome}" enable_localSystem="${options.allowRootDirectory}" />\n` + distInfo.substring(insertIndex) | |||
| if (options.license) { | |||
There was a problem hiding this comment.
We should not require explicit option.
- use getLicenseFiles util method to autodetect (see other implementations).
- disable autodetect of option explicitly set to null — triple equals
There was a problem hiding this comment.
Would you like me to do something like this?
http://www.cocoabuilder.com/archive/xcode/319021-add-localized-readme-license-etc-in-distribution-package-using-productbuild.html
in your resource folder, add the localized folders, but named English.proj, French.proj, German.proj (they will be renamed as en.proj, fr.proj, de.proj by productbuild) containing your localized Welcome.rtf (for example), and use the --resources option.
There was a problem hiding this comment.
At first I think we should add basic implementation, and add localized later. If you want to add localization righ now — great. If not — it is ok too, you are not forced to prepare polished full featured PR.
Thanks for info. Yes, we can automatically creates such files for productbuild since localized licenses supported for DMG/nsis.
There was a problem hiding this comment.
In order not to make unnecessary pushes, could you please tell me if my approach is right or not:
if (options.license !== null) {
const licenseFiles = await getLicenseFiles(this.packager)
const license = await this.packager.getResource(options.license, ...licenseFiles.map(f => f.file))
if (license != null) {
const licensePath = path.join(this.packager.info.projectDir, license)
distInfo = distInfo.substring(0, insertIndex) + ` <license file="${licensePath}"/>\n` + distInfo.substring(insertIndex)
}
}…set 'license' to null explicitly
|
Any comments on my new changes, please? |
|
Released as 19.43.0, thanks. |
No description provided.