Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passing through binaries and requirements options #1574

Closed
wants to merge 1 commit into from

Conversation

feens
Copy link
Contributor

@feens feens commented May 23, 2017

In order to properly sign helpers, such as keytar (used for keychain access), the specific binary needs to be signed.
electron-osx-sign allows this but there was no way to pass these through, so allow the option(s) in package.json.
Additionally, the mac (not app store) apps need requirements sent to ensure helper acts are recognized properly.

Also: the mas-dev target wasn't being allowed, so I fixed that.

…ning cases

In order to properly sign helpers, such as keytar (used for keychain access), the specific binary needs to be signed.
electron-osx-sign allows this but there was no way to pass these through, so allow the option(s) in package.json.
Additionally, the mac (not app store) apps need requirements sent to ensure helper acts are recognized properly.
@feens
Copy link
Contributor Author

feens commented May 23, 2017

Back story: we were having issues getting our desktop app to properly sign the for MAS. Our app uses keytar to handle keychain storage, but it (keytar) needs to be properly signed otherwise it will show a warning when accessing keychain items that were created with the app.

@develar
Copy link
Member

develar commented May 23, 2017

Paths of any extra binaries that need to be signed

But electron-osx-sign must automatically detect such binaries. User should not explicitly specify it.

@feens
Copy link
Contributor Author

feens commented May 23, 2017

But electron-osx-sign must automatically detect such binaries. User should not explicitly specify it.

It doesn't necessarily though. We found that out the hard way when we were using electron-packager and electron-osx-sign to build the non-MAS version. It seems that keytar seems to be a bit of a special case and we're still figuring out some issues with it. This at least allows users to pass in the option, otherwise it will detect as it normally would.

@develar
Copy link
Member

develar commented May 23, 2017

This at least allows users to pass in the option, otherwise it will detect as it normally would.

👍 In any case I cannot promise that I will investigate this case in a reasonable time. But user should be able to pass it explicitly.

@feens
Copy link
Contributor Author

feens commented May 23, 2017

@develar That's fine. I think being as it's likely a one-off there's not much sense in you spending a ton of time trying to figure out why. I think it makes sense to just pass through as many options as possible along with sensible defaults...that way other developers can just override when they need specific behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants