fix(updater): GitHub private repo for windows, partial solution for #1370 #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial solution for electron-userland#1370
|
@AlienHoboken, thanks for your PR! By analyzing the history of the files in this pull request, we identified @maczikasz and @kevinphelps to be potential reviewers. |
|
In the future please do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial solution for #1370. This fixes private github provider for auto updates on Windows.
However it is know that Mac still does not work, this is due to how squirrel.mac uses feed URL and cannot have its headers controlled on redirect. A solution for this is being investigated.