Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron-auto-updater) Checking for updates from github was failing #1068

Closed

Conversation

badams
Copy link
Contributor

@badams badams commented Dec 31, 2016

Appears that github are now more strict about the Accept header, and invalid requests are resulting in a 406 response

I've adjusted the httpExecutor.request method to allow for custom header objects to be passed, so user can specify header (eg. Accept: application/json)

I've also updated the way we retrieve the latest version tag;
when sending Accept: application/json to /:user/:repo/releases/latest github will respond with a JSON payload like below

{
  "tag_name": "v1.0.0",
  ...
}

So it can be easily extracted without relying on redirect headers or the official API

#1038 #1058

@mention-bot
Copy link

@badams, thanks for your PR! By analyzing the history of the files in this pull request, we identified @maczikasz to be a potential reviewer.

@develar
Copy link
Member

develar commented Dec 31, 2016

Amazing! Thanks a lot. For some technical (unrelated) reasons PR cannot be accepted right now, but I hope to merge it today.

@develar
Copy link
Member

develar commented Dec 31, 2016

Don't worry about merge conflicts :)

@develar
Copy link
Member

develar commented Dec 31, 2016

[email protected] (tag: next) published with your fix. Tag next because I don't have time to make all tests and we don't yet have special electron tests.

@develar develar closed this Dec 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants