fix(electron-auto-updater) Checking for updates from github was failing #1068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears that github are now more strict about the
Accept
header, and invalid requests are resulting in a 406 responseI've adjusted the httpExecutor.request method to allow for custom header objects to be passed, so user can specify header (eg.
Accept: application/json
)I've also updated the way we retrieve the latest version tag;
when sending
Accept: application/json
to/:user/:repo/releases/latest
github will respond with a JSON payload like belowSo it can be easily extracted without relying on redirect headers or the official API
#1038 #1058