fix: order of platform and arch npm env vars #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnolle
added a commit
to voidbridge/electron-builder
that referenced
this pull request
Dec 24, 2016
* commit 'dcf3dbb48979291fb91301610de9e417e0ab7b79': (43 commits) feat: LSTypeIsPackage for file associations fix: Trim suffix from wine version (electron-userland#1033) fix: Stub Executables missing in Squirrel.Windows 1.5.1 fix: order of platform and arch npm env vars (electron-userland#1029) feat: Set platform npm environment variable feat: Use Electron.Net to send http requests for auto updater docs: typo (electron-userland#1026) refactor: reexport HttpError feat(appx): more customizable manifest fields chore: prefer const feat: 32 bit appx fix: yarn detection feat: update Squirrel.Windows to 1.5.1 fix: update nsis to 3.0.1 docs: Added details about setting AUMID for Windows 8/8.1 notifications. fix: update nsis to 3.0.1 test: attempt to make Win CI green test: use yarn on Appveyor fix: ENOENT for symlinks because directory was not created fix(electron-auto-updater): load default provider only if custom was not set ... # Conflicts: # src/cli/install-app-deps.ts # src/cli/node-gyp-rebuild.ts # src/packager.ts # src/publish/restApiRequest.ts # src/targets/nsis.ts # src/util/httpRequest.ts # src/yarn.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1027 (comment)