Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wine version check fails (wine-x (Staging)) #953

Closed
JorisM opened this issue Nov 30, 2016 · 11 comments
Closed

Wine version check fails (wine-x (Staging)) #953

JorisM opened this issue Nov 30, 2016 · 11 comments
Labels

Comments

@JorisM
Copy link

JorisM commented Nov 30, 2016

Electron-builder version: 10.3.0

Target: win32

I'm working on Fedora 25 with wine --version --> wine-1.9.22 (Staging)

If I try to run: ./node_modules/.bin/build --win it results in an error:

Skip app dependencies rebuild because platform is different
TypeError: Invalid Version: 1.9.22 (Staging)

I'm assuming this error happens because it cannot parse the (Staging) part of the version correctly
If I switch to wine --version --> wine-1.9.24 everyting works fine

@JorisM
Copy link
Author

JorisM commented Nov 30, 2016

Possible fix, change this line:
https://github.com/electron-userland/electron-builder/blob/master/src/packager.ts#L305

to:
wineVersion = wineVersion.substring("wine-".length).split(" ")[0]

@ml1nk
Copy link
Contributor

ml1nk commented Nov 30, 2016

I had the same problem and created a (now merged) pull request:
#955

@develar develar closed this as completed Nov 30, 2016
@develar develar added the bug label Nov 30, 2016
@Avien
Copy link

Avien commented Dec 6, 2016

This is still happens to me on latest version 10.5.0 when trying to build on ubuntu ci (gitlab)
Skip app dependencies rebuild because platform is different
TypeError: Invalid Version: it

@ml1nk
Copy link
Contributor

ml1nk commented Dec 6, 2016

What is the output of wine --version on your system?

@Avien
Copy link

Avien commented Dec 6, 2016

looks like its 1.62 I suspected its the problem,
but when trying to run with specific version like: apt-get install --no-install-recommends -y wine1.8 I get an error:

E: Unable to locate package wine1.8
E: Couldn't find any package by regex 'wine1.8'

@ml1nk
Copy link
Contributor

ml1nk commented Dec 6, 2016

What exactly is the output of "wine --version"? Normally you should see a message like wine 1.8+ is required, but your version is ${wineVersion} if your version is too old, which means the processing of the string fails.

I don't know which ubuntu release you use, but for older ones the ppa https://launchpad.net/~ubuntu-wine/+archive/ubuntu/ppa provides a more recent wine version.

@develar
Copy link
Member

develar commented Dec 6, 2016

I have added test and it is green. So, please answer to @ml1nk question.

@Avien
Copy link

Avien commented Dec 6, 2016

I'm sorry, I was not around
I managed to solve it, upgraded ubuntu to 16.04 , wine 1.8 could not be installed on older ubuntu
so it installed 1.6 by default
Now its fine
Thank you very much for your help

@mentos1386
Copy link

It fails on arch with wine version wine-2.0-rc1

@cawa-93
Copy link
Contributor

cawa-93 commented Dec 21, 2016

It fails on Ubuntu 16.10 with wine version wine-2.0-rc2

@adlingepa
Copy link

In my case it gives me below error,

prashant@L-10750:~/work/buildhost$ wine ––version
04b4:err:module:process_init L"C:\\windows\\system32\\\2013\2013version.exe" not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants