-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron-builder not generating "latest.yml" file on Windows (NSIS) #925
Comments
It will be uploaded automatically. Local file is not created. (JFYI: Also, So, please specify |
Isn't that a bug though? What if I DON'T want electron-builder to automatically publish releases to GitHub? What if I want to:
In both of these use cases, it would be handy for electron-builder to place a Otherwise the user is forced to write a small Python script or something to manually generate the |
Yes, it is bug. It the reason why issue was not closed. Should be addressed. |
Ok, great. Thank you for your continued support develar. =) |
Both files should be generated regardless of publish state. I spent 20 minutes to understand why my local test app cannot be updated due to missed |
@develar Any progress on this? I'd be happy to jump in and help debug this if you're not already elbow-deep into fixing it. |
Fix requires deep understanding what electron-builder does and how. Some design decision should be made. In short: we cannot generate latest.yml for GitHub as file in the local fs for now due to special file escaping rules for Github releases. And I really don't want to introduce special folder in the dist for that, but I am going to try to avoid such escaping/transformation. So, only I can fix this issue :( |
Just to be clear, this issue effects |
No, only |
It's only github? I'm not seeing the latest.yml being generated for generic releases. UPDATE: Never mind... worked this time. No idea what I messed up before... sheesh. Keep up the good work! |
Solution "use product name everywhere and replace space to _" failed. Because GitHub doesn't allow unicode as well in the asset name. |
|
Just add line on "package.json" |
@Oscarato ... only if you really use generic provider and not Github. otherwise you must not do it because GitHub url is different. |
exactly.... |
I cannot get app-update.yml to be generated at all. Nor latest.yml for that matter but app-update is what's causing my updates to error out. How exactly am I supposed to make these generate? I'm trying to run a build with "publish" set in my package.json like so:
I initially tried |
@obermillerk https://www.electron.build/auto-update
|
@develar so electron-updater is not usable with squirrel at all? |
@obermillerk Yes. |
That is unfortunate... Also, the phrasing "Simplified auto-update" does not make it clear that the whole library is not usable with squirrel. I assume it would be quite a chore adding support for squirrel? If it's something you've considered doing it would be greatly appreciated, as the built in autoUpdater is very limiting but I'm not sure that we would want to use NSIS. |
Squirrel.Windows is limited and no plans to support it. NSIS is feature-rich, proven and widely used solution. |
Gonna switch over to NSIS. Thanks for all your work on this project, it's phenomenal. |
To make clear — Squirrel.Windows is limited in all aspects. User customizability, feature set, debugability. Not suitable for a lot of users. Our principle — do not reinvent the wheel. Nsis allows us to easily implement features/requests instead of writing yet another Windows installer tool. And a lot of users simply write own maintainable installer scripts without need to wait upstream. |
I'm seeing this issue in Electron Builder starting with (I think) v19.47.x on Windows 7 x64. I see a |
I'm seeing this issue again with I haven't been able to build for a while, so I can't say with any level of precision where this began to occur again, but in version between Thoughts? |
Also seeing this issue in 22.14.5 mifi/lossless-cut#621 |
This helps me fix the issue. Correction, it's "win": { "publish": { "provider": "generic", "url": "localhost"} } |
Target: win32 x64
Build command:
npm run dist --python="C:/Python27/python.exe"
Console output:
After building my app, I get a
Racing+ Setup 0.0.1.exe
in mydist
subfolder. This is all well and good. But shouldn't there be alatest.yml
there too? I need to upload that file to my GitHub releases page in order for automatic updating to work. Where am I supposed to get thelatest.yml
file?The text was updated successfully, but these errors were encountered: