Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable "unpack execuatable" #879

Closed
zh99998 opened this issue Nov 5, 2016 · 4 comments · May be fixed by qcif/data-curator#563
Closed

disable "unpack execuatable" #879

zh99998 opened this issue Nov 5, 2016 · 4 comments · May be fixed by qcif/data-curator#563

Comments

@zh99998
Copy link

zh99998 commented Nov 5, 2016

I have a module contains executable binary files, but they never execute them directly, only copy them to outside directory via fs. It works in asar packages.

Is there any way to say don't unpack these module, just put them into asar package?

@develar
Copy link
Member

develar commented Nov 5, 2016

Is there any way to say don't unpack these module, just put them into asar package?

No. In general, it is ok — doesn't affect performance. Does it lead to runtime error?

@zh99998
Copy link
Author

zh99998 commented Nov 5, 2016

no, just lead to uncomfortable

@develar
Copy link
Member

develar commented Nov 5, 2016

If it doesn't lead to any runtime error and conditional statements in the code, then I am going to close won't fix. Don't you mind?

@zh99998 zh99998 closed this as completed Nov 5, 2016
@develar develar added the wontfix label Nov 5, 2016
develar added a commit to develar/electron-builder that referenced this issue Nov 5, 2016
@develar
Copy link
Member

develar commented Nov 5, 2016

Log level changed from info to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants