-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
25.0.5 builds broken due to missing native binaries #8431
Comments
Can you provide a minimal reproducible demo code? |
Unfortunately I cannot, this is the electron app of a private repository, and recreating the same scenario with a native node module isn't doable publicly right now. I am going to test 25.0.3 to see if it worked prior to #8392 |
Can you reproduce this using a public native Node module along with your Electron Builder configuration? |
25.0.3 also did not work. If I find time I will make a repro project |
updating to v25.0.5 from 24.13.3 was also breaking our builds example of failure:
no 'minimal reproducer' :-/ but repository is public in the tree: (need to fetch this exact commit to reproduce the bug) using Node.js v20 and then moving back to v24.13.3 works, using latest 25.0.5 the binary is no longer starting. |
Fixes crash on launch possibly caused by electron-userland/electron-builder#8431
I am having a lot of issues with macos-14 github action runners and hdiutil errors, so I tried upgrading to 25.0.5 for the retry logic it has. This results in the build breaking, seemingly related to native modules going missing for both macOS and windows. The latest 24.x works.
The text was updated successfully, but these errors were encountered: