Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code signing for windows and mac in macOS #822

Closed
popod opened this issue Oct 13, 2016 · 4 comments · May be fixed by qcif/data-curator#563
Closed

Code signing for windows and mac in macOS #822

popod opened this issue Oct 13, 2016 · 4 comments · May be fixed by qcif/data-curator#563

Comments

@popod
Copy link
Contributor

popod commented Oct 13, 2016

  • Version: 7.13.0
  • Target: macOS and Win (squirrel and nsis)

Could you provide different env variable for signing osx and win ?

with build -mw --x64 --ia32 with CSC_LINK and CSC_KEY_PASSWORD set with certificat for win and CSC_NAME for macOS certificat, the build don't work ! Building separately for mac and win work fine..

If I set certificateFile and certificatePassword in place of CSC_LINK and CSC_KEY_PASSWORD in package.json build.win, it don't work again.

Could you try that and give me the right configuration ? Thank

@develar
Copy link
Member

develar commented Oct 17, 2016

If I set certificateFile and certificatePassword in place of CSC_LINK and CSC_KEY_PASSWORD in package.json build.win, it don't work again.

As far I see, it should work — certificateFile is checked before CSC_LINK.

In any case — WIN_CSC_LINK env was added. (please use the same password for win and mac certs).

@popod
Copy link
Contributor Author

popod commented Oct 25, 2016

Thanks for answer. Why should I use the same password for win and mac certs ? This is not my case, so why could we not define different pass for mac and win ?

@develar
Copy link
Member

develar commented Oct 25, 2016

Fixed. WIN_CSC_KEY_PASSWORD will be supported in next electron-builder version.

develar added a commit to develar/electron-builder that referenced this issue Oct 25, 2016
@popod
Copy link
Contributor Author

popod commented Oct 25, 2016

Perfect ! Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants