Custom Windows Signing does not work when signing to a different location

[sdesmond46]

• Electron-Builder Version****: 24.4.0

• Node Version: 18.15.0

• Electron Version: 25.8.3
• Electron Type (current, beta, nightly): current

• Target: Windows

When providing a custom sign function to the windows config section you have the option to set a resultOutputPath which is then supposed to be copied over the original file by electron-builder. However, where the actual sign function is called the object is passed using the spread operator which means you are modifying a copy of the context instead of the context itself. This then means that you never have a value for resultOutputPath set where the renaming is supposed to happen.

Minimal repo:

  win: {
    signingHashAlgorithms: ['sha256'],
    sign: async (context) => {
      // This should cause a failure when copying the file but it does not
      context.resultOutputPath = 'foo';
    },
    target: ['nsis'],
  },

[mmaietta]

Nice find! Would you be willing to open a PR with the needed changes?