-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't throw an error if version doesn't start with `v´ #743
Comments
Problem is that we search version by v-prefixed tag name — https://github.com/electron-userland/electron-builder/blob/master/src/publish/gitHubPublisher.ts#L53 Solution — use both variants to find and log warn instead of throwing error. |
@develar That sounds like a great way to handle it! |
@develar Is this a big change? Probably not, right? Is there are chance that you could fix this and release a patch? We're going to release a big thing and would like to use this feature for it. |
@leo Sorry, I missed your last message. Fixed.
|
@develar Cool, thanks! 👍 😊 |
IMHO, there's no reason to strictly throw an error here. Instead of doing that, we should just log the suggestion and let things like Travis CI simply pass on with other tasks.
For example: At HyperTerm we're not using the "v" (because there's simply no point in using it), but we would still like to use the "GitHub publisher" feature... 😊
The text was updated successfully, but these errors were encountered: