Mac code signing compatibility with @electron/osx-sign 1.0.4

[mayfield]

• Electron-Builder Version: 24.0.0-alpha.7

• Node Version: 16

• Electron Version: 22.0.0
• Electron Type (current, beta, nightly): current

• Target: mac

I'm in the process of updating to electron-builder 24 and having issues with code signing. It looks like EB is using the legacy "identity-validation" property

electron-builder/packages/app-builder-lib/src/macPackager.ts

Line 273 in ffe9967

"identity-validation": false,

which should be camelCase now.

More importantly, while tracking this down, it became clear there is some conflated use of the options.identity string and the return value of the findIdentity function that returns an osx-sign Identity object. In EB versions before 24 the legacy identity-validation=false working properly would mask this for my particular use case.

At this line, I think the identity value should be qualifer instead of the Identity instance.

electron-builder/packages/app-builder-lib/src/macPackager.ts

Line 297 in ffe9967

identity: identity,

[mayfield]

At this line, I think the identity value should be qualifer instead of the Identity instance.

Or perhaps identity: identity ? identity.name : undefined

[mayfield]

I have this untested patch as an example mayfield@8557a66

I was going to attempt a PR but I failed to achieve success manual or unit testing in a reasonable amount of time. I ended up implementing an afterPack hook in my project instead that monkey patches the current code as follows...

SauceLLC/sauce4zwift@e4e722f

[panther7]

Last worked version is 24.0.0-alpha.5.

[mmaietta]

Thanks for calling this out. Would you be willing to open a PR with the value change?

[filfreire]

Also noticed this in our project, https://github.com/Kong/insomnia/actions/runs/3846215323/jobs/6551824759#step:5:146

⨯ No identity found for signing.  failedTask=build stackTrace=Error: No identity found for signing.
    at signApp (/Users/runner/work/***/***/packages/***/node_modules/@electron/osx-sign/src/sign.ts:360:13)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at MacPackager.sign (/Users/runner/work/***/***/packages/***/node_modules/app-builder-lib/src/macPackager.ts:324:5)
    at /Users/runner/work/***/***/packages/***/node_modules/app-builder-lib/src/macPackager.ts:452:9

We are using "app-builder-lib": "24.0.0-alpha.8"