Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall Confirm Dialog Option for One-click Windows NSIS #618

Closed
dharders opened this issue Jul 29, 2016 · 7 comments · May be fixed by qcif/data-curator#563
Closed

Uninstall Confirm Dialog Option for One-click Windows NSIS #618

dharders opened this issue Jul 29, 2016 · 7 comments · May be fixed by qcif/data-curator#563

Comments

@dharders
Copy link

  • Version: 5.19.0
  • Target: Win32 NSIS One-click

Can we please add an option (or have it default behaviour) to have a simple "Are you sure you want to uninstall {{AppName}} ?" dialog popup when using the Add/Remove Programs feature of Windows ?

Motivation: Prevent unintentional data loss (from selecting the wrong program by mistake). Also it is standard Windows behaviour to have a confirmation dialog before uninstall.

@develar
Copy link
Member

develar commented Jul 29, 2016

screen shot 2016-07-29 at 11 32 13

Windows 10 asks you about it. Is it not enough (I am not Windows user)?

@dharders
Copy link
Author

Yes, that screenshot for Windows 10 is correct behaviour (I had only tested win 7 when posted the issue).

That's the 'new' Windows 10 "Add or remove programs" feature and that works as expected (I have since tested on Win 10). However, in Windows 10 there is also a "Change or remove a program" feature (God, bless them and their consistency!) and that is where the unexpected behaviour is happening (this is the Windows 7 way too, via Control Panel). To find the feature in Win10, just type 'change or remove' in the search bar (or find it in Control Panel) and hopefully you'll see the behaviour I'm describing.

(side-issue: if I click Uninstall while App is running, nothing happens...I assume exception is swallowed silently? Should we also prompt like install "Click OK to close running app..." ?)

@develar develar closed this as completed in e99047d Aug 2, 2016
@dharders
Copy link
Author

dharders commented Aug 3, 2016

I just tried your 5.22.1 release with your fix and the confirm dialog still does not popup for Win10 "Change or remove a program" and Win7. It still uninstalls without prompting.

Am I missing something?

@develar
Copy link
Member

develar commented Aug 5, 2016

(side-issue: if I click Uninstall while App is running, nothing happens...I assume exception is swallowed silently? Should we also prompt like install "Click OK to close running app..." ?)

Fixed.

It still uninstalls without prompting.

Fixed.

Cause: SilentUnInstall equals to /S — but we need partial silent, so, granular SetSilent is used as a solution.

@dharders
Copy link
Author

dharders commented Aug 5, 2016

Awesome work!

I confirm that the fix in 5.23.1 is now working for both Win7 and Win10 (both uninstall variants)!

Perfect and thanks!

@adicojo
Copy link

adicojo commented Aug 5, 2017

Hello,

How can we skip the confirmation dialog <Are you sure you want to completely remove {AppName} and all of its components?> when the /S switch is used for a NSIS uninstallation? It prevents the uninstall from being unattended...

Thank you.

@ismoil793
Copy link

ismoil793 commented Mar 13, 2024

Hi @adicojo, it has been a while, but anyway did you find how to skip that confirmation screen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants