Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage should have arch in filename #594

Closed
probonopd opened this issue Jul 17, 2016 · 3 comments · May be fixed by qcif/data-curator#563
Closed

AppImage should have arch in filename #594

probonopd opened this issue Jul 17, 2016 · 3 comments · May be fixed by qcif/data-curator#563
Assignees

Comments

@probonopd
Copy link

probonopd commented Jul 17, 2016

  • Version: master
  • Target: Linux AppImage

The recommended filename for an AppImage is AppName-1.0.1-x86_64.AppImage - this makes it easier for users to know which file to download. This would also allow me to do away with workarounds like this in automated AppImage generation.

probonopd added a commit to AppImageCommunity/pkg2appimage that referenced this issue Jul 17, 2016
@develar
Copy link
Member

develar commented Jul 17, 2016

Our convention for all targets that arch for x64 is not included in the name. Because x64 should be default (e.g., as macOS supports only x64). When you build for ia32, arch will be specified in the name. But I think this convention should be changed according to AppImage format.

@develar
Copy link
Member

develar commented Jul 19, 2016

Also, we use currently x64 (as node process.arch identifier). But I remember AppImage/AppImageKit#178 (comment) and

develar@ubuntu:~$ arch
x86_64

So, I don't like it, but... ok, we will use such suffix. Just want to be sure that it is really needed.

@develar
Copy link
Member

develar commented Jul 19, 2016

What suffix should we use for ia32?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants