Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Silicon can’t auto-update with Universal target #5639

Closed
EtienneLem opened this issue Feb 17, 2021 · 6 comments
Closed

Apple Silicon can’t auto-update with Universal target #5639

EtienneLem opened this issue Feb 17, 2021 · 6 comments

Comments

@EtienneLem
Copy link

  • Version: 22.10.4
  • Electron Version: 11.2.3
  • Electron Type (current, beta, nightly): current
  • Target: Universal (macOS)

Getting a Error: No files provided error when trying to auto-update. A current workaround is to launch the app with Rosetta enabled, auto-update, disable Rosetta.

[2021-02-15 14:03:01.269] [info] Checking for update
[2021-02-15 14:03:02.638] [info] Found version 9.50.1 (url: App-9.50.1-mac.zip, App-9.50.1.dmg)
[2021-02-15 14:03:02.639] [info] Downloading update from App-9.50.1-mac.zip, App-9.50.1.dmg
[2021-02-15 14:03:02.640] [error] Error: Error: No files provided
    at newError (App.app/Contents/Resources/app-arm64.asar/node_modules/builder-util-runtime/out/index.js:212:17)
    at findFile (App.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/out/providers/Provider.js:111:46)
    at MacUpdater.doDownloadUpdate (App.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/out/MacUpdater.js:80:50)
    at MacUpdater.downloadUpdate (App.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/out/AppUpdater.js:577:19)
    at MacUpdater.doCheckForUpdates (App.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/out/AppUpdater.js:537:49)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

/cc @lutzroeder in case you have an idea since you implemented #5481

@lutzroeder
Copy link
Contributor

Duplicate of #5495

@EtienneLem
Copy link
Author

Duplicate of #5495

Oh, is it? I did rename the artifacts as the workaround suggests in that issue. Had no problem migrating from Intel build to Universal.

Good to know if that's the same issue, it felt like a different one.

@lutzroeder
Copy link
Contributor

lutzroeder commented Feb 17, 2021

The underlying issue is that electron-updater is hardcoded to probe for a file that has no architecture-specific extension. There are many different ways to go about this. The #5495 change is to specify that the universal targets (instead of x64) use the default extension. There hasn't been a new electron-builder preview since this commit was merged.

@EtienneLem
Copy link
Author

Understood! We’ll wait for the next preview release. Thanks 🤘🏼

mb21 added a commit to mb21/panwriter that referenced this issue Jan 29, 2022
by changing output from PanWriter-0.8.2-mac to PanWriter-0.8.2-x64-mac

This should prevent Intel Macs from downloading the ARM build.

see electron-userland/electron-builder#5639 (comment)
dragonworr added a commit to dragonworr/panwriter that referenced this issue Jun 15, 2023
by changing output from PanWriter-0.8.2-mac to PanWriter-0.8.2-x64-mac

This should prevent Intel Macs from downloading the ARM build.

see electron-userland/electron-builder#5639 (comment)
@maoryadin
Copy link

Same issue, any way to make it work?

@nop33
Copy link

nop33 commented May 27, 2024

We've also been experiencing this issue recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants