fix(nsis): output files sometimes locked by virus scanners (#5005) #5143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue which I've observed (and documented in issue #5005) with a McAfee virus scanner: After NSIS is writing the first part of the EXE, the virus scanner locks the file for further writing for a while, which causes the second write to fail and makes it impossible to build on my work laptop, because I'm not allowed to exclude certain files from the scanner. This fix checks whether the file is writable. If not it waits and checks again every 2s until the file is released by the scanner. A corresponding message is written to the console.