Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on allowPrerelease, pre-releases, and auto-updates with channels #4988

Closed
eengoron opened this issue May 19, 2020 · 1 comment

Comments

@eengoron
Copy link

Electron Builder Version:
22.4.0

Electron Updater Version:
4.2.0

Hey Electron Builder Team,

I was hoping I could get some clarification on the expected behavior of using allowPrerelease with update channels in electron-builder because I'm noticing a weird issue on my end. Here's the situation:

I use a public Github repository as my provider for releases, and I have 3 update channels in my application alpha, beta, and latest.

I noticed that if I have autoUpdater.channel = 'beta' and autoUpdater.allowPrerelease = 'true' set in my app, and I pre-release a new version on the alpha channel, the autoUpdater will see the new alpha pre-release while on the beta channel and upgrade.

For instance, if I'm currently on v4.0.5 of my application with my autoUpdater.channel = 'beta' and autoUpdater.allowPrerelease = 'true' and then I pre-release version 4.0.6-alpha in my releases repo, when I check for updates again, even though I'm on the beta channel, the autoUpdater will start downloading 4.0.6-alpha.

Is this to be expected? Note: This does not happen if I release version 4.0.6-alpha. This only happens when 4.0.6-alpha is in the pre-release state on GH.

Thanks!

@eengoron
Copy link
Author

eengoron commented Jun 3, 2020

Turns out, channels are not supported with Github as the provider. See: #1722 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant