can you add supports for makensis INPUTCHARSET OUTPUTCHARSET?

[hdfeng265]

• Version: app-builder-lib@22.4.1@app-builder-lib
• Electron Version: 5.0.4
• Target: build

My windows charset is gbk, when i use makensis.exe to compile utf-8 nsis script, i got a "Bad text encoding" error.

Makensis.exe has option to specify input charset, but electron-builder seem doesn't have this option.
Can you add supports for makensis INPUTCHARSET OUTPUTCHARSET? Thanks!!

Temporarily, i modified "node_modules/electron-builder/node_modules/app-builder-lib/out/targets/nsis/NsisTarget.js" and "NsisTarget.js.map" by insert " args.push("-INPUTCHARSET", "UTF8", "-OUTPUTCHARSET", "UTF8");" into line 724, to support utf-8 nsis script.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[woxixiulayin]

same problem here.We have to use custom nsis script in electorn-builder, but got "Bad text encoding" error.We have to use INPUTCHARSET option with makensis. Any fix for that?

[sohobloo]

These is useful to fix custom scripts encoding issues. Why closed.

[mmaietta]

Is there a particular reason why we wouldn't want the input and output charsets to be utf8? Seems like those args would be beneficial to just use by default.

Any reason to not use utf16 instead btw?