Windows NSIS uninstall fails when built from MacOS Catalina #4875

fkoehler42 · 2020-04-14T19:53:37Z

Version: 22.4.1
Electron Version: 7.2.1
Electron Type (current, beta, nightly): current
Electron Updater Version: 4.2.5
Target: Windows NSIS (tested on Windows 7 and 10)

I recently switched to Mac OS 10.15 (Catalina) which doesn't support 32 bit executables anymore. Doing so, I also upgraded electron-builder to the latest version so Wine isn't used.

Since then, my Windows NSIS uninstaller seems broken. The build process works as expected, no error/warning raised. However, after the first install of my app which works well, I face a NSIS error when I try to uninstall. This is the common "Installer integrity check has failed" error. When I try to either manually reinstall the app or update it using electron-updater, the installer progress bar stays stuck at around 40%.

My build config is the default one. I tried some tweaks suggested on similar issues but none of them helped. If I build my app from a previous MacOS version the issue disappears.

shrinidhi111 · 2020-04-15T15:13:44Z

I had to downgrade to 21.2.0 to fix my issue #4878

fkoehler42 · 2020-04-15T15:22:35Z

Unfortunately this issue seems different: I got no warning from Windows Defender. I tried to downgrade electron-builder to 21.x, as well as turning off the "Windows Defender real-time protection". (Issue appears also on Windows 7 BTW)

Snake231088 · 2020-04-16T17:44:57Z

Same issue!
Any solution or workaround?

BusinessDuck · 2020-04-18T11:52:54Z

Same for me!

Affected by this reg key. Clean it and problem is gone. I think something wrong with nsis templates.

BusinessDuck · 2020-04-18T16:30:49Z

Hack solution (good once for oneClick):

"nsis": {
      "guid": "MyAppName",
      "include": "build/installer.nsh",
    },

build/installer.nsh listing

!macro customInit
    DeleteRegKey HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\MyAppName"
!macroend

fkoehler42 · 2020-04-20T20:42:01Z

@BusinessDuck I tried to remove the UninstallString key but doing so makes Windows think my app has already been uninstalled so the program is removed from the control panel without being actually uninstalled

BusinessDuck · 2020-04-21T08:08:48Z

use !macro customUnInstall instead

pafa7a · 2020-05-03T03:53:01Z

Building with MacOS Catalina 10.15.4 and experiencing the same issues on Windows.
Custom removal in nsis scripts didn't worked at all (was not triggered).
When building the installer from Windows machine everything works well...

matt-cree-instil · 2020-05-04T09:49:40Z

I'm also experiencing the same issues -- building on Windows for Windows works fine.

andywang646691 · 2020-05-12T03:06:07Z

This problem exists in many electron-builder versions, and has not been fixed until now. just try a hack, and modify electron-builder source code:

comment code and throw error so that electron-builer can builds installer by parallels vm.
The source code maybe from node_modules/app-builder-lib/out/targets/nsis/NsisTarget.js or node_modules/electron-builder/node_modules/app-builder-lib/out/targets/nsis/NsisTarget.js

The hint come from here

ouzhou · 2020-06-29T06:53:38Z

same issue

simple-YoungBadBoy · 2020-08-09T03:14:31Z

Same issue!
Any solution or workaround?

matt-cree-instil · 2020-08-09T09:00:26Z

Build your Windows installer in a docker container. Their docs mention how to do this.

…

On Sun, 9 Aug 2020, 04:14 simple, ***@***.***> wrote: Same issue! Any solution or workaround? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4875 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOLPJ7GYXV6G57GP5W4L3YTR7YICHANCNFSM4MIAH6WQ> .

stale · 2020-10-10T03:43:49Z

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

aschmid · 2020-10-19T19:54:26Z

same issue here. :(

Ali-Albaker · 2020-11-13T16:48:13Z

same issue

gentlecoder · 2020-11-17T08:59:43Z

Same here. I use /NCRC to uninstall it, works fine for me.

lauritzen · 2020-11-17T09:07:32Z

Same here. I worked around it by building "on Windows" with the electronuserland/builder:wine Docker image on MacOS, more info here: https://www.electron.build/multi-platform-build#build-electron-app-using-docker-on-a-local-machine. The script I'm using:

docker run --rm \
       --env-file <(env | grep -vE '\r|\n' | grep -iE 'DEBUG|NODE_|ELECTRON_|YARN_|NPM_|CI|CIRCLE|TRAVIS_TAG|TRAVIS|TRAVIS_REPO_|TRAVIS_BUILD_|TRAVIS_BRANCH|TRAVIS_PULL_REQUEST_|APPVEYOR_|CSC_|GH_|GITHUB_|BT_|AWS_|STRIP|BUILD_') \
       --env ELECTRON_CACHE="/root/.cache/electron" \
       --env ELECTRON_BUILDER_CACHE="/root/.cache/electron-builder" \
       -v ${PWD}:/project \
       -v ${PWD}/docker-node-modules:/project/node_modules \
       -v ~/.cache/electron:/root/.cache/electron \
       -v ~/.cache/electron-builder:/root/.cache/electron-builder \
       electronuserland/builder:wine \
       /bin/bash -c "yarn --link-duplicates --pure-lockfile && yarn electron:publish"

olegdolenchuk · 2021-02-10T09:44:21Z

same issue

takuyabz · 2021-02-26T09:40:59Z

same issue

takuyabz · 2021-02-26T10:46:05Z

This issue cause is building on mac.
You should build on a windows environment.
I installed the parallels desktop on Mac, and build it for windows.
Then I succeeded uninstall on windows.
please try this solution, thank you.

LukeXF · 2021-07-03T16:58:07Z

Same issue, can't understand why this is such a big issue

tjx666 · 2021-08-09T09:54:17Z

Still exits....

mmaietta · 2021-08-24T03:58:57Z

This is the recommended solution: https://www.electron.build/multi-platform-build#build-electron-app-using-docker-on-a-local-machine

Happy to review a PR if anyone would like to open one. Setting up a local dev environment is fairly simple: https://github.com/electron-userland/electron-builder/blob/master/CONTRIBUTING.md#to-setup-a-local-dev-environment

Ali-Albaker · 2022-10-07T14:28:40Z

Still exists. It's best to use Windows OS, VM or docker to make the build

adamcjm · 2023-01-29T06:03:51Z

I find a way to solve this problem:

You can try to add a line code with the content CRCCheck off to bottom of the file node_modules/app-builder-lib/templates/nsis/common.nsh.
And then rebuild and install the application to windows, and try to uninstall or update.

these two step fixed my problem.

adamcjm · 2023-01-29T06:04:04Z

Still exists. It's best to use Windows OS, VM or docker to make the build

I find a way to solve this problem:

You can try to add a line code with the content CRCCheck off to bottom of the file node_modules/app-builder-lib/templates/nsis/common.nsh.
And then rebuild and install the application to windows, and try to uninstall or update.

these two step fixed my problem.

adamcjm · 2023-01-29T06:04:15Z

Still exits....

I find a way to solve this problem:

You can try to add a line code with the content CRCCheck off to bottom of the file node_modules/app-builder-lib/templates/nsis/common.nsh.
And then rebuild and install the application to windows, and try to uninstall or update.

these two step fixed my problem.

adamcjm · 2023-01-29T06:04:25Z

Same issue, can't understand why this is such a big issue

I find a way to solve this problem:

You can try to add a line code with the content CRCCheck off to bottom of the file node_modules/app-builder-lib/templates/nsis/common.nsh.
And then rebuild and install the application to windows, and try to uninstall or update.

these two step fixed my problem.

ErnestLeung52 · 2023-02-02T19:55:09Z

I find a way to solve this problem:

You can try to add a line code with the content CRCCheck off to bottom of the file node_modules/app-builder-lib/templates/nsis/common.nsh.

And then rebuild and install the application to windows, and try to uninstall or update.

these two step fixed my problem.

This works for me!!! Thank you!

itsdouges · 2023-05-18T02:45:27Z

When you turn CRCCheck off is there any unintended consequences of that? Does code signing become at risk?

fkoehler42 mentioned this issue Jun 5, 2020

package-win-32 error #4937

Closed

stale bot added the backlog label Oct 10, 2020

stale bot closed this as completed Oct 17, 2020

terror2012 mentioned this issue Dec 16, 2020

Uninstall fail on windows terror2012/electronApp#8

Closed

alex8088 mentioned this issue Nov 15, 2023

Installer integrity check has failed. common causes includeincomplete download and damaged media. contact theinstaller's author to obtain a new copy More information at.http://nsis.sfnet/NSIS Error alex8088/electron-vite#334

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows NSIS uninstall fails when built from MacOS Catalina #4875

Windows NSIS uninstall fails when built from MacOS Catalina #4875

fkoehler42 commented Apr 14, 2020 •

edited

Loading

shrinidhi111 commented Apr 15, 2020

fkoehler42 commented Apr 15, 2020

Snake231088 commented Apr 16, 2020

BusinessDuck commented Apr 18, 2020 •

edited

Loading

BusinessDuck commented Apr 18, 2020 •

edited

Loading

fkoehler42 commented Apr 20, 2020 •

edited

Loading

BusinessDuck commented Apr 21, 2020

pafa7a commented May 3, 2020

matt-cree-instil commented May 4, 2020 •

edited

Loading

andywang646691 commented May 12, 2020 •

edited

Loading

ouzhou commented Jun 29, 2020

simple-YoungBadBoy commented Aug 9, 2020

matt-cree-instil commented Aug 9, 2020 via email

stale bot commented Oct 10, 2020

aschmid commented Oct 19, 2020

Ali-Albaker commented Nov 13, 2020

gentlecoder commented Nov 17, 2020 •

edited

Loading

lauritzen commented Nov 17, 2020

olegdolenchuk commented Feb 10, 2021

takuyabz commented Feb 26, 2021

takuyabz commented Feb 26, 2021

LukeXF commented Jul 3, 2021

tjx666 commented Aug 9, 2021

mmaietta commented Aug 24, 2021 •

edited

Loading

Ali-Albaker commented Oct 7, 2022

adamcjm commented Jan 29, 2023

adamcjm commented Jan 29, 2023

adamcjm commented Jan 29, 2023

adamcjm commented Jan 29, 2023

ErnestLeung52 commented Feb 2, 2023

itsdouges commented May 18, 2023

Windows NSIS uninstall fails when built from MacOS Catalina #4875

Windows NSIS uninstall fails when built from MacOS Catalina #4875

Comments

fkoehler42 commented Apr 14, 2020 • edited Loading

shrinidhi111 commented Apr 15, 2020

fkoehler42 commented Apr 15, 2020

Snake231088 commented Apr 16, 2020

BusinessDuck commented Apr 18, 2020 • edited Loading

BusinessDuck commented Apr 18, 2020 • edited Loading

fkoehler42 commented Apr 20, 2020 • edited Loading

BusinessDuck commented Apr 21, 2020

pafa7a commented May 3, 2020

matt-cree-instil commented May 4, 2020 • edited Loading

andywang646691 commented May 12, 2020 • edited Loading

ouzhou commented Jun 29, 2020

simple-YoungBadBoy commented Aug 9, 2020

matt-cree-instil commented Aug 9, 2020 via email

stale bot commented Oct 10, 2020

aschmid commented Oct 19, 2020

Ali-Albaker commented Nov 13, 2020

gentlecoder commented Nov 17, 2020 • edited Loading

lauritzen commented Nov 17, 2020

olegdolenchuk commented Feb 10, 2021

takuyabz commented Feb 26, 2021

takuyabz commented Feb 26, 2021

LukeXF commented Jul 3, 2021

tjx666 commented Aug 9, 2021

mmaietta commented Aug 24, 2021 • edited Loading

Ali-Albaker commented Oct 7, 2022

adamcjm commented Jan 29, 2023

adamcjm commented Jan 29, 2023

adamcjm commented Jan 29, 2023

adamcjm commented Jan 29, 2023

ErnestLeung52 commented Feb 2, 2023

itsdouges commented May 18, 2023

fkoehler42 commented Apr 14, 2020 •

edited

Loading

BusinessDuck commented Apr 18, 2020 •

edited

Loading

BusinessDuck commented Apr 18, 2020 •

edited

Loading

fkoehler42 commented Apr 20, 2020 •

edited

Loading

matt-cree-instil commented May 4, 2020 •

edited

Loading

andywang646691 commented May 12, 2020 •

edited

Loading

gentlecoder commented Nov 17, 2020 •

edited

Loading

mmaietta commented Aug 24, 2021 •

edited

Loading