Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(linux): New fileAssociation support produces wrong xml that cannot be parsed #4089

Closed
nicodorn opened this issue Jul 25, 2019 · 2 comments
Closed

bug(linux): New fileAssociation support produces wrong xml that cannot be parsed #4089

nicodorn opened this issue Jul 25, 2019 · 2 comments

Comments

@nicodorn
Copy link

nicodorn commented Jul 25, 2019 •
edited
Loading

  • Version: 21.1.3
  • Target: linux(deb)

The commit c11fa1f produces wrong xml that cannot be parsed correctly. The problem are two closing </mime-info>. Simply omit line 40 of the commit and add the backtick to line 39. Then everything should be fine.
@develar
Copy link
Member

develar commented Jul 25, 2019

Should be already fixed in 21.1.5

@develar develar closed this as completed Jul 25, 2019
develar added a commit to develar/electron-builder that referenced this issue Jul 25, 2019
@develar
test(deb): check file associations
f8daf43 
Close electron-userland#4089
@nicodorn
Copy link
Author

It is indeed. Pardon me!

develar added a commit to develar/electron-builder that referenced this issue Jul 31, 2019
@develar
test(deb): check file associations
371296a 
Close electron-userland#4089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@develar @nicodorn