-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Build ends with [object Object] #4045
Comments
Corrected:
|
@Alnarra I run into a problem like this too! I think this is a bug, in my case, the problem is the icon.ico file is wrong somehow. When I remove the ico file, packing will success, the bug is, in version 21.x.x the error message can not be shown successfully, (instead, [object object] was shown), so it is hard for the user to find what is wrong. And 20.x.x version has no problem like this. |
Maybe we should open this issue again to let maintainer notice this |
Same here. I had to downgrade as well. @Alnarra can you reopen this issue? |
Per Request, Reopening |
Hello guys! I created my icons with GIMP and what caused the issue to me was saving the icon files with no compression, so when I tried again but this time by checking "PNG compression" it went all good: • electron-builder version=21.1.1 os=10.0.17134 I hope it helps :) |
In my case I got this, anyone can help? I'm using a working NSIS custom script but I got this error ... |
Hi @aziks, In my case I got this, anyone can help? I'm using a working NSIS custom script but I got this error ... |
Hi Every body, |
Hi Folks, I'm facing the same problem. |
Illegal filename change to Normal filename |
same problem here. I am using 256x256 png for the icon. above solutions did not work for me. <<<<< building for windows on linux >>>> `
` |
Using electron-builder: v21.2.0 #4045 (comment) https://forum.getkirby.com/t/how-to-make-a-proper-compressed-favicon-ico/2725 |
I had same issue but for me nothing from above worked. I have tried PNG compression as mentioned above with no luck. |
Just wanted to add that I also get an error My workaround was to downgrade to electron-builder 20.44.4 (as mentioned above) which allowed me to get a proper log output to investigate the issue. In my case I had misspelled the name of a directory in my So I guess my point is, the error logging seems broken in 22.1.0 |
Similar issue with version 22.2.0 for https://github.com/4ian/GDevelop Here are the logs in the hope it's helpful. I compiled with
Happy to provide other informations or open a new issue if needed. |
Version The same version works fine on TravisCI where I am building for Linux and MacOS. Downgrading to |
* Release v0.21.1 * Downgrade electron-builder + update deps electron-userland/electron-builder#4045 (comment)
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@hovancik I don't known why the issue is closed but I still get same error with both electron-builder version 20.44.4 and 21.2.0: uninstaller is not signed by electron-builder reason=custom NSIS script is used version 20.44.4 does provide more information but failed to generate the uninstaller, either. here is my config:
I have to use my custom "installer.nsi" because I want to override some macro in "multiUser.nsh", the only difference between my "installer.nsi" and default "installer.nsi" is: #!include "multiUser.nsh" I am not sure when this issue will be fixed. |
@lvbeck try latest version, I am not having this issue anymore |
@hovancik I upgraded to the latest 22.6.0, now another error occurred:
|
@lvbeck did you found the solution to your issue? |
@alphonsoTheGreat still not, I will test the next release later. |
I'm on version 22.7.0 and have the same issue. |
@talhaanees if you don't have custom NSIS script "script": "build/installer.nsi" in the nsis section, try version 20.44.4, this works only with "include": "build/installer.nsh". for me, I have to override the default installer.nsi completely, there is no working solution. |
So, I did some playing around and eventually it did work for me with the latest version (22.7.0). Still doesn't work with this version in Ext SSD. But it works with 20.44.4 in both cases. |
Electron Updater Version:^4.1.2
Electron Version: 5.0.6
When attempting to build for Windows on a Windows Native client The process proceeds as expected
• electron-builder version=21.0.15 os=10.0.17134
• loaded configuration file=package.json ("build" field)
• writing effective config file=dist\builder-effective-config.yaml
• packaging platform=win32 arch=x64 electron=5.0.6 appOutDir=dist\win-unpacked
• building target=nsis file=dist\project.exe archs=x64 oneClick=true perMachine=false
⨯ [object Object]
And does not seem to make an exe of any kind in the /dist folder. There is no further information then [object Object]. It may be worth noting that when building the same project for Mac and Linux it completes successfully and without issue. I have also tried to make use of the docker image under the Multi Platform section, it ends with the same error when attempting to build for windows.
The text was updated successfully, but these errors were encountered: