-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: buffer is not ico #349
Comments
Please check that your |
D'oh! Thanks! |
Reopened — the error message is unclear and must be fixed. |
@daviseford Please clarify — ico file was invalid (why?) or didn't exist? |
I copied the /build directory from https://github.com/develar/onshape-desktop-shell/. Apparently the .ico files in that directory were not valid. The file did exist, but even my Mac couldn't open them - files must have been corrupted or something. After I replaced icon.ico with a new, valid icon, the build worked. |
@daviseford onshape-desktop-shell uses GIT LFS to store binary files. If you clone repo without installed GIT LFS, you get just text pointers. Thanks for clarification. |
@develar |
@demetris-manikas We already check update: this issue is open because instead of unclear error message we should check that buffer is a string and throw error like "It seems it is a GIT LFS pointer, please check that GIT LFS is installed" |
Hey there, when I try to build the win32 version of my app, I receive this error
Error: buffer is not ico
at parseIco (/Users/loaner/opat-presentation/native/node_modules/electron-builder/src/winPackager.ts:202:11)
at /Users/loaner/opat-presentation/native/node_modules/electron-builder/src/winPackager.ts:185:25
at [object Generator].next (native)
at /Users/loaner/opat-presentation/native/node_modules/electron-builder/node_modules/fs-extra-p/node_modules/fs-extra/node_modules/graceful-fs/graceful-fs.js:43:10
at /Users/loaner/opat-presentation/native/node_modules/electron-builder/node_modules/read-package-json/node_modules/graceful-fs/graceful-fs.js:43:10
at FSReqWrap.oncomplete (fs.js:82:15)
From previous event:
at tsAwaiter (/Users/loaner/opat-presentation/native/node_modules/electron-builder/src/awaiter.ts:10:51)
at Object.build (/Users/loaner/opat-presentation/native/node_modules/electron-builder/src/builder.ts:30:59)
at Object. (/Users/loaner/opat-presentation/native/node_modules/electron-builder/src/build-cli.ts:41:2)
at Module._compile (module.js:409:26)
at Object.Module._extensions..js (module.js:416:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Function.Module.runMain (module.js:441:10)
at startup (node.js:139:18)
at node.js:968:3
The Mac and Linux versions of my project build just fine. At first I thought this error might be related to my "iconUrl", but haven't had any luck switching it. Has anyone else run into this issue?
The text was updated successfully, but these errors were encountered: