-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoupdater fails on MacOS X #3377
Comments
I'm having this too. I'm building and failing update on Majave but both users that reported errors updating are on Sierra and High Sierra :( |
Adding this to package.json helps with the nsapp error
|
@gseregni it must be in old app or in new? Because in new app it doest have effect. But if old - how to update already installed apps? No way? |
@dafivius Unfortunately i think you have now way to update automatically the old app if you already shipped it with electron updater 3.1.2 and electron 3. |
@dafivius the problem may exists only on some OSX versions.. here at Pingendo we reverted back to electron 2 |
@gseregni yep. Reverted back to 1.8, all ok. Making two versions of package json for macos and (linux/windows). No another idea yet. Need to keep working of app with existed users. |
@dafivius i think it's not possible to have autoupdater back to work for users already updated, unless they dont' install your app again. |
Any official word on the cause anywhere yet? |
@develar any news here ? |
@dafivius I was having this problem and I solved using the following versions: electron: 3.0.5 package.json:
|
@juliocesaroliveira That didn't seem to solve mine... @develar - Can you at least fill us in on why there's no official word on this? Did we miss something in an update note or readme somewhere? |
@framerate no info. We decided to migrate to newest electron version with @juliocesaroliveira notes. Everything works fine yet. |
Please try next pre-release versions:
|
Please never use |
Apple Transport Security doesn't make sense for Electron applications because restrictions are not enforced to both NodeJS and Electron net API. As Squirrel.Mac doesn't support file urls now, electron-updater forced to use proxy to pipe local file to Squirrel.Mac. I decided to set |
Is this confirmed fix? I updated my versions according to @develar but latest version didn't patch again... Probably user error but I'd love confirmation from somebody. |
electron-builder 20.36.2 and electron-updater 4.0.4 are latest versions that were tested and proven to be working. If not, please provide steps to reproduce. |
Awesome. I think I'm using versions posted above
I'll update this weekend and verify. Thanks! |
@framerate To clarify — I fixed one bug, then discovered another one, then added another improvement, then I decided to require Electron 3 (to simplify testing and to use new Electron features). That's why so many electron-updater versions recently :) |
I appreciate your work! I have enough on my plate without having to make building and updating tools myself :) |
@develar Not sure if this helps you or if it's just user error but I updated using Here's the end of the log . that looks "failed" if it helps. I'm going to spend some time this week setting up a test update server to really dive deep. I haven't had one setup because updates have been rock solid for almost 2 years! |
Strange URL in your logs — do you really use electron-updater or native
directly?
…On Tuesday, November 20, 2018, Justin Reynard ***@***.***> wrote:
@develar <https://github.com/develar> Not sure if this helps you or if
it's just user error but I updated using electron-builder 20.36.2 and
electron-updater 4.0.4 twice (so the version on my computer and the one
on the server were built with the same version) but still doesn't update
Here's the end of the log . that looks "failed" if it helps.
[image: image]
<https://user-images.githubusercontent.com/74291/48796428-74a46780-ecb4-11e8-9537-59b3add3abcf.png>
I'm going to spend some time this week setting up a test update server to
really dive deep. I haven't had one setup because updates have been rock
solid for almost 2 years!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3377 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVZ3kWaJ_crJEBgiuKfBsjeyKh1bc8pks5uxFOsgaJpZM4XVM0G>
.
|
Hmm. Honestly that's a good question. I have it set up based on your read me files from about 2 years ago and have never had to change anything. It worked perfectly through to electron 3.0 update. I serve my updates through my CDN. Sounds like I may have to revisit my setup? |
@develar thanks for pointing that out. I update to latest electron-updater and it works WAY better! |
According to Apple documentation (https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CocoaKeys.html#//apple_ref/doc/uid/TP40009251-SW35) NSAllowsLocalNetworking is not available for macOS 10.12 and older. The workaround for Supporting Older Operating Systems: |
I think @alexdrimbe is right, also discussed at #3525 (comment) |
Apple docs:
|
…able in older operating systems (iOS 10.0 and older, or macOS 10.12 and older) Close electron-userland#3377
@aguynamedben Thanks for donation, electron-builder 20.38.3 is released. 930dc8d |
👏🙏Thank you for the hard work on electron-builder. It's truly great. |
@develar Can you provide stable versions of electron-builder and electron-updater to be used in order to get over this issue? When I use
while building App I am getting Does this mean It is not signing the application? |
Might fix auto-update issue (see electron-userland/electron-builder#3377)
I am facing the same issue, and neither it is fixed in latest version nor by using My download url is on http. I see the ATS error in logs
I change the plist via mac.extendInfo config.
More info to debug
|
@makeitcount If your app has been built with You must explicitly define domains which are allowed to be requested via non-secure HTTP protocol.
By the way, thank you, @develar , for your efforts on maintaining this project. |
Updated to the latest version of Electron. Everything build and publishing good. We are using amazon s3 provider. Files are available.
But when i'm trying to update an application (it downloads it but can't install) - getting following error:
Error: The resource could not be loaded because the App Transport Security policy requires the use of a secure connection. at /Applications/Our.app/Contents/Resources/app.asar/node_modules/graceful-fs/polyfills.js:287:18 at FSReqWrap.oncomplete (fs.js:183:5) From previous event: at Object.done (/Applications/Our.app/Contents/Resources/app.asar/node_modules/electron-updater/src/MacUpdater.ts:46:11) at /Applications/Our.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:530:25 at Generator.next (<anonymous>) at runCallback (timers.js:696:18) at tryOnImmediate (timers.js:667:5) at processImmediate (timers.js:649:5) at process.topLevelDomainCallback (domain.js:121:23)
...
It was OK on version 1.8.* but i can't migrate to 3.0.3 because of that issue. What can i do with it? Thanks.
The text was updated successfully, but these errors were encountered: