Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify custom build-version for electron-packager #323

Closed
antelle opened this issue Apr 16, 2016 · 1 comment · May be fixed by qcif/data-curator#563
Closed

Allow to specify custom build-version for electron-packager #323

antelle opened this issue Apr 16, 2016 · 1 comment · May be fixed by qcif/data-curator#563
Labels

Comments

@antelle
Copy link

antelle commented Apr 16, 2016

Currently build-version for electron-packager (i.e. build number) is returned from env variable here. I'm using build number as commit sha from gitinfo grunt task. That would be great to allow specifying custom build number as builder.build option.
Workaround:

require('electron-builder/out/platformPackager')
    .PlatformPackager.prototype.computeBuildNumber = function() { return ...; }
@develar
Copy link
Member

develar commented Apr 16, 2016

In progress. Do not send PR — there is some TS design issue (nullability). Fix will be today/tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants