Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows code signing from OS X #314

Closed
feross opened this issue Apr 14, 2016 · 7 comments · May be fixed by qcif/data-curator#563
Closed

Windows code signing from OS X #314

feross opened this issue Apr 14, 2016 · 7 comments · May be fixed by qcif/data-curator#563

Comments

@feross
Copy link

feross commented Apr 14, 2016

What's left to do to make this work?

@develar
Copy link
Member

develar commented Apr 15, 2016

Time. Only time. And issue from user. Now we have the issue ;)

@feross
Copy link
Author

feross commented Apr 16, 2016

Nice, glad I could help out 👍

But seriously, let me know if there's any way to help out.

According to @kevinsawicki's comment, signcode only supports MD5 and SHA1 signing, which are both deprecated. We might want to look at using SignTool if that's possible to use from wine. Or maybe osslsigncode, as suggested.

@kevinsawicki
Copy link

kevinsawicki commented Apr 18, 2016

I published a new signcode module late last week that wraps osslsigncode.

It has both a CLI and API, https://github.com/kevinsawicki/signcode#cli

@kevinsawicki
Copy link

kevinsawicki commented Apr 18, 2016

By default it signs with both sha1 and sha256 signatures.

@feross
Copy link
Author

feross commented Apr 19, 2016

@kevinsawicki Nice!

develar added a commit to develar/electron-builder that referenced this issue Apr 20, 2016
@develar
Copy link
Member

develar commented Apr 20, 2016

@kevinsawicki Thanks a lot. Works like a charm. We should add linux version of osslsigncode and specify os to not install this module on Windows, but it can be addressed later.

  • electron-builder uses signcode to sign app exe regardless of Squirrel.Windows (because electron-builder is a smart facade of electron-packager/will pack into sfx/7z/zip/etc soon)
  • installer is signed by windows-installer (my fork) — PR will be this/next week.

develar added a commit to develar/electron-builder that referenced this issue Apr 20, 2016
@develar
Copy link
Member

develar commented Apr 20, 2016

Please note — all releases are now as next, i.e. npm update will not update to it. Use next. Once someone confirm that it works, it will be marked as latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants