Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSI for Win10 does not have working Notification #2906

Closed
saifelse opened this issue May 14, 2018 · 0 comments · Fixed by #2908
Closed

MSI for Win10 does not have working Notification #2906

saifelse opened this issue May 14, 2018 · 0 comments · Fixed by #2908

Comments

@saifelse
Copy link
Contributor

saifelse commented May 14, 2018

In the PR to follow, I've confirmed that adding app.setAppUserModelId(appId), along with such a shortcut configured in the WXS file causes new Notification(...).show() to work in at least Win10.

References:

"A shortcut to your app, with a System.AppUserModel.ID, must be installed to the Start screen. Note, however, that it does not need to be pinned to the Start screen. For more information, see How to enable desktop toast notifications through an AppUserModelID."

saifelse added a commit to benchling/electron-builder that referenced this issue May 14, 2018
develar pushed a commit that referenced this issue May 14, 2018
…10 (#2908)

* fix(msi): put appId in start menu shortcut to fix notifications in win8/win10

Close #2906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants