Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single quote in a product name leads to NSIS failure #2686

Closed
gemma-ferreras opened this issue Mar 12, 2018 · 4 comments
Closed

Single quote in a product name leads to NSIS failure #2686

gemma-ferreras opened this issue Mar 12, 2018 · 4 comments

Comments

@gemma-ferreras
Copy link

gemma-ferreras commented Mar 12, 2018

Hi everyone!

I am having issues to do the build in windows (mac and linux is working).

  • Electron-builder version: 20.4.0
  • Target: platform=win32 arch=x64

The build falls down at:

[1] npm run build-renderer exited with code 0
• electron-builder version=20.4.0
• loaded configuration file=package.json ("build" field)
• writing effective config file=release/electron-builder.yaml
• installing production dependencies platform=win32 arch=x64 appDir=/Users/local/repos/desktop/app
• packaging platform=win32 arch=x64 electron=1.7.5 appOutDir=release/win-unpacked
• building target=nsis-web file=release/nsis-web/testing Web Setup 0.6.0.exe archs=x64 oneClick=true
• building embedded block map file=release/nsis-web/0.6.0-x64.nsis.7z

`Error: /Users/desktop/Library/Caches/electron-builder/nsis/nsis-3.0.1.13/mac/makensis exited with code 1
Error output:
DetailPrint expects 1 parameters, got 3.
Usage: DetailPrint message
Error in macro CHECK_APP_RUNNING on macroline 15
!include: error in script: "uninstaller.nsh" on line 10
Error in script "" on line 150 -- aborting creation process

at ChildProcess.childProcess.once.code (/Users/local/repos/desktop/node_modules/builder-util/src/util.ts:252:14)
at Object.onceWrapper (events.js:317:30)
at emitTwo (events.js:126:13)
at ChildProcess.emit (events.js:214:7)
at maybeClose (internal/child_process.js:925:16)
at Socket.stream.socket.on (internal/child_process.js:346:11)
at emitOne (events.js:116:13)
at Socket.emit (events.js:211:7)
at Pipe._handle.close [as _onclose] (net.js:554:12)`

log.txt
package.txt

Any help would be appreciated.

Thanks

@develar
Copy link
Member

develar commented Mar 14, 2018

What's your product name of app?

@gemma-ferreras
Copy link
Author

@develar it is in the log file. I added all the error. Thanks for checking

@develar
Copy link
Member

develar commented Mar 14, 2018

Not a regression. Product name contains '.

@gemma-ferreras
Copy link
Author

@develar I added the package.json so you can check. Thanks

@develar develar changed the title makensis exited with code 1 Single quote in a product name leads to NSIS failure Mar 18, 2018
develar added a commit to develar/electron-builder that referenced this issue Mar 18, 2018
develar added a commit to develar/electron-builder that referenced this issue Mar 18, 2018
develar added a commit to develar/electron-builder that referenced this issue Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants